Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vite plugin docs #157

Merged
merged 4 commits into from
Nov 12, 2024
Merged

Vite plugin docs #157

merged 4 commits into from
Nov 12, 2024

Conversation

theoephraim
Copy link
Member

clarifying vite plugin usage for ssr and dynamic config

Copy link

changeset-bot bot commented Nov 11, 2024

⚠️ No Changeset found

Latest commit: c7638c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for signup-api canceled.

Name Link
🔨 Latest commit 10a8deb
🔍 Latest deploy log https://app.netlify.com/sites/signup-api/deploys/6732a46cde1c000008c47ee2

Copy link

netlify bot commented Nov 11, 2024

Deploy Preview for dmno ready!

Name Link
🔨 Latest commit 10a8deb
🔍 Latest deploy log https://app.netlify.com/sites/dmno/deploys/6732a46c0d9f9500081b78db
😎 Deploy Preview https://deploy-preview-157--dmno.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@theoephraim theoephraim force-pushed the vite-plugin-dynamic branch 2 times, most recently from bf5c039 to 683c0a8 Compare November 11, 2024 22:50
Copy link
Contributor

@philmillman philmillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job! just a few nits

:::

### Using env vars within `vite.config.*`
It's often useful to be able to access configuration / env vars within your vite config. Without DMNO, it's a bit awkward, but DMNO makes it dead simple - in fact it's already available! Just reference config vars via `DMNO_CONFIG.SOME_ITEM` like you do everywhere else.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It's often useful to be able to access configuration / env vars within your vite config. Without DMNO, it's a bit awkward, but DMNO makes it dead simple - in fact it's already available! Just reference config vars via `DMNO_CONFIG.SOME_ITEM` like you do everywhere else.
It's often useful to be able to access configuration / env vars within your Vite config. Without DMNO, it's a bit awkward, but DMNO makes it dead simple - in fact it's already available! Just reference config vars via `DMNO_CONFIG.SOME_ITEM` like you do everywhere else.

Copy link

pkg-pr-new bot commented Nov 12, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@dmno/vite-integration@157

commit: 10a8deb

Copy link

pkg-pr-new bot commented Nov 12, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@dmno/vite-integration@157

commit: 10a8deb

@theoephraim theoephraim merged commit ccd00ce into main Nov 12, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants